Skip to content

Conversation

@schneems
Copy link
Contributor

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.

Discussed in:

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 26, 2025
@schneems schneems marked this pull request as ready for review November 26, 2025 23:42
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 031cd0b to 7e93561 Compare November 26, 2025 23:46
@rustbot

This comment has been minimized.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 7e93561 to 44f98ba Compare November 26, 2025 23:49
@rustbot

This comment has been minimized.

@schneems schneems force-pushed the schneems/get_resolved_envs branch from 44f98ba to 1567085 Compare November 26, 2025 23:50
@bors
Copy link
Collaborator

bors commented Nov 27, 2025

☔ The latest upstream changes (presumably #149368) made this pull request unmergeable. Please resolve the merge conflicts.

This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.
@schneems schneems force-pushed the schneems/get_resolved_envs branch from 1567085 to 674da7d Compare November 27, 2025 14:09
@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed (and commit squashed for that nit)

I also added a few unresolved questions to the tracking issue but I don't think they're blockers for merging the initial implementation.

View changes since this review

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2025
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
 Documenting std v0.0.0 (/checkout/library/std)
error: unresolved link to `Command::get_resolved_envs`
   --> library/std/src/sys/process/env.rs:119:34
    |
119 | /// This struct is returned by [`Command::get_resolved_envs`].
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `Command` in scope
    |
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

error: could not document `std`
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] std test:false 8.317
Bootstrap failed while executing `doc library --stage 1`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo doc --target x86_64-unknown-linux-gnu -Zbinary-dep-depinfo -j 4 -Zroot-dir=/checkout --locked --color always --release -p alloc -p compiler_builtins -p core -p panic_abort -p panic_unwind -p proc_macro -p rustc-std-workspace-core -p std -p std_detect -p sysroot -p test -p unwind --features 'backtrace panic-unwind compiler-builtins-c' --manifest-path /checkout/library/sysroot/Cargo.toml --no-deps --target-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc -Zskip-rustdoc-fingerprint -Zrustdoc-map [workdir=/checkout]` failed with exit code 101
Created at: src/bootstrap/src/core/build_steps/doc.rs:795:21
Executed at: src/bootstrap/src/core/build_steps/doc.rs:828:22

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:05
  local time: Mon Dec  8 14:16:52 UTC 2025
  network time: Mon, 08 Dec 2025 14:16:52 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants