-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Add Command::get_resolved_envs #149362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Command::get_resolved_envs #149362
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
031cd0b to
7e93561
Compare
This comment has been minimized.
This comment has been minimized.
7e93561 to
44f98ba
Compare
This comment has been minimized.
This comment has been minimized.
44f98ba to
1567085
Compare
|
☔ The latest upstream changes (presumably #149368) made this pull request unmergeable. Please resolve the merge conflicts. |
This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.
1567085 to
674da7d
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with nit fixed (and commit squashed for that nit)
I also added a few unresolved questions to the tracking issue but I don't think they're blockers for merging the initial implementation.
Co-authored-by: Mark Rousskov <[email protected]>
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This addition allows an end-user to inspect the environment variables that are visible to the process when it boots.
Discussed in:
Commandcaptured env var logic #149070 (partially closes)Commandcaptured env var logic libs-team#194